Skip to content

bind to loopback only #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2021
Merged

bind to loopback only #476

merged 1 commit into from
Nov 12, 2021

Conversation

dnadoba
Copy link
Collaborator

@dnadoba dnadoba commented Nov 11, 2021

Motivation

Binding to all available interface may result in a firewall popup on macOS. We don't want that for our automated tests.

Changes

Only bind to the local loopback adapter instead of all interfaces.

@dnadoba dnadoba merged commit 68f283c into swift-server:main Nov 12, 2021
@dnadoba dnadoba deleted the dn-bind-to-loopback-only branch November 12, 2021 09:08
@dnadoba dnadoba added the semver/none No version bump required. label Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianfett fabianfett fabianfett approved these changes

Assignees
No one assigned
Labels
semver/none No version bump required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnadoba @fabianfett